Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update req.query when rewrite without params #432

Merged
merged 3 commits into from
Dec 8, 2016
Merged

update req.query when rewrite without params #432

merged 3 commits into from
Dec 8, 2016

Conversation

Nilegfx
Copy link
Contributor

@Nilegfx Nilegfx commented Dec 7, 2016

fixes #431

@typicode
Copy link
Owner

typicode commented Dec 7, 2016

Thank you @Nilegfx, could you add a test here?
https://github.com/typicode/json-server/blob/master/test/server/plural.js#L689

@Nilegfx Nilegfx changed the title update req.query when rewrite without params fixes #431 update req.query when rewrite without params Dec 8, 2016
@typicode
Copy link
Owner

typicode commented Dec 8, 2016 •
edited
Loading

Thanks :)

@typicode typicode merged commit 202a416 into typicode:master Dec 8, 2016
@Nilegfx
Copy link
Contributor Author

Nilegfx commented Dec 8, 2016

most welcome. thank YOU for this amazing piece of software.

@Nilegfx Nilegfx deleted the bugfix/update-queries-when-rewrite branch December 9, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rewrite url when no params fails to pass query strings
2 participants
@Nilegfx @typicode